C#: Update .NET 8 Runtime models. #16872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click to show differences in coveragecsharpGenerated file changes for csharp
- System,"``System.*``, ``System``",44,10614,60,9
+ System,"``System.*``, ``System``",47,10626,54,5
- Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``JsonToItemsTaskFactory``, ``Microsoft.Android.Build``, ``Microsoft.Apple.Build``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NET.WebAssembly.Webcil``, ``Microsoft.VisualBasic``, ``Microsoft.WebAssembly.Build.Tasks``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",54,1821,148,
+ Others,"``Amazon.Lambda.APIGatewayEvents``, ``Amazon.Lambda.Core``, ``Dapper``, ``ILCompiler``, ``ILLink.RoslynAnalyzer``, ``ILLink.Shared``, ``ILLink.Tasks``, ``Internal.IL``, ``Internal.Pgo``, ``Internal.TypeSystem``, ``JsonToItemsTaskFactory``, ``Microsoft.Android.Build``, ``Microsoft.Apple.Build``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.Diagnostics.Tools.Pgo``, ``Microsoft.DotNet.Build.Tasks``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.Diagnostics.Metrics``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NET.WebAssembly.Webcil``, ``Microsoft.VisualBasic``, ``Microsoft.WebAssembly.Build.Tasks``, ``Microsoft.Win32``, ``Mono.Linker``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``SourceGenerators``, ``Windows.Security.Cryptography.Core``",57,1821,148,
- Totals,,98,12442,402,9
+ Totals,,104,12454,396,5
- Microsoft.Android.Build,,,16,,,,,,,,,,,,,,,,,,,16,
+ Microsoft.Android.Build,,1,16,,,,,,,,,,,,,1,,,,,,16,
- Microsoft.Extensions.Configuration,,2,90,,,,,,,,,,,,,2,,,,,,89,1
+ Microsoft.Extensions.Configuration,,3,90,,,,,,,,,,,,,3,,,,,,89,1
- Microsoft.Extensions.DependencyModel,,,18,,,,,,,,,,,,,,,,,,,18,
+ Microsoft.Extensions.DependencyModel,,1,18,,,,,,,,,,,,,1,,,,,,18,
- System,60,44,10614,,7,6,5,,,4,5,,33,2,,3,15,17,3,4,,8709,1905
+ System,54,47,10626,,6,5,5,,,4,1,,33,2,,6,15,17,3,4,,8721,1905 |
michaelnebel
force-pushed
the
csharp/updatedotnetmodels
branch
2 times, most recently
from
cec568e
to
e6df6db
Compare
michaelnebel
force-pushed
the
csharp/updatedotnetmodels
branch
from
ad998bd
to
f7e5e6d
Compare
github-actions
bot
added
documentation
and removed
C++
Java
Go
Swift
DataFlow Library
labels
michaelnebel
force-pushed
the
csharp/updatedotnetmodels
branch
2 times, most recently
from
3f1939c
to
6d9985f
Compare
michaelnebel
force-pushed
the
csharp/updatedotnetmodels
branch
from
6d9985f
to
e5b0471
Compare
michaelnebel
force-pushed
the
csharp/updatedotnetmodels
branch
from
e5b0471
to
c8d301e
Compare
hvitved
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update the .NET 8 Runtime models. Since the last update there has been several updates to the model generator that affects the model generator output.
With respect to source models, we introduce neutrals for a couple of the generated models as they are not sources (even though flow is detected, the conditions that apply on the path means that they are not sources).
That is, we exclude
get_SystemDirectory(this can be excluded as this is not a source due to a hardcoded constant).GetPreviousVersionandget_ProcessNamemight come from a serialised value from disc, but I don’t think we should generally consider these file or file-write source.Running DCA using the new (local) sources, we get many new results (especially for the
cs/tainted-pathquery). I have spot checked some of these on the powershell project and all the new results (that I checked) are due to theGetTempPathandGetFolderPathsources.GetTempPathreads the temp directory value from an environment variable (so this should be considered anenvironmentsource) andGetFolderPathin some cases reads from the environment (if eg. the path to the current users home folder is requested). TheGetFolderPathis a more speculative source, but lets include it and see if we get many false positive alerts.